Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): modal center positioning #707

Merged
merged 2 commits into from
Nov 1, 2019
Merged

Conversation

artyorsh
Copy link
Collaborator

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

This closes #699
But the issue may persist for the interactive window resizing since there is no way to do something like

window.addEventListener('resize', () => { ... });

Related issue necolas/react-native-web#60

@artyorsh artyorsh added needs review 📱 Components components module-specific 🌐 Web react-native-web specific labels Oct 30, 2019
@artyorsh artyorsh self-assigned this Oct 30, 2019
Co-Authored-By: Yauhen <e.penkin@akveo.com>
@artyorsh artyorsh merged commit 301e3f4 into master Nov 1, 2019
@artyorsh artyorsh deleted the fix/modal-center-position branch November 1, 2019 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 Web react-native-web specific 📱 Components components module-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal positioned by screen size (not browser size) on web
2 participants