Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/35 potential duplicate checker bug #36

Merged
merged 3 commits into from
May 31, 2023
Merged

Feature/35 potential duplicate checker bug #36

merged 3 commits into from
May 31, 2023

Conversation

wayangalihpratama
Copy link
Contributor

TODO/DONE

  • Update category.json, add a custom config
  • Update potential duplicate checker to check only in the same category name
  • Update get_category util, get valid list only from the same category config
  • Add views test case, to filter by new custom category

@wayangalihpratama wayangalihpratama self-assigned this May 31, 2023
ifirmawan
ifirmawan approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@ifirmawan ifirmawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it by adding a new category with the same question and option and its works as expected (no duplication)
Screenshot 2023-05-31 at 15 49 22

@ifirmawan ifirmawan merged commit 6d82064 into main May 31, 2023
3 checks passed
@dedenbangkit dedenbangkit deleted the feature/35-potential-duplicate-checker-bug branch June 1, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifirmawan ifirmawan ifirmawan approved these changes

@dedenbangkit dedenbangkit Awaiting requested review from dedenbangkit

Assignees

@wayangalihpratama wayangalihpratama

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wayangalihpratama @ifirmawan