Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/23 app preference page #25

Merged
merged 35 commits into from
Jul 2, 2023
Merged

Feature/23 app preference page #25

merged 35 commits into from
Jul 2, 2023

Conversation

ifirmawan
Copy link
Contributor

@ifirmawan ifirmawan commented Jun 26, 2023 •
edited
Loading

TODO/DONE

Features

  • Create Settings page.
  • Create FormSettings page.
  • Save configuration to global state.
  • Save configuration to SQLite.

Request changes

  • Move tests related to the Components/Pages
  • Rename FormAction to ManageForm

Unit tests

  • Settings page as a snapshot
  • SettingsForm
  • DialogForm

@ifirmawan ifirmawan self-assigned this Jun 26, 2023
Base automatically changed from feature/21-setup-initial-state to main June 27, 2023 04:50
@ifirmawan ifirmawan force-pushed the feature/23-app-preference-page branch from ef7a934 to 570933c Compare June 27, 2023 09:34
@ifirmawan ifirmawan force-pushed the feature/23-app-preference-page branch from 1079f4a to bd17a1f Compare June 27, 2023 14:12
@ifirmawan ifirmawan force-pushed the feature/23-app-preference-page branch from 19bcd48 to 1b98638 Compare June 28, 2023 08:35
@ifirmawan ifirmawan marked this pull request as ready for review June 28, 2023 08:37
dedenbangkit
dedenbangkit requested changes Jun 29, 2023
View reviewed changes
app/src/pages/FormAction.js Outdated Show resolved Hide resolved
app/__tests__/pages/Settings.test.js Outdated Show resolved Hide resolved
app/__tests__/components/Stack.test.js Outdated Show resolved Hide resolved
app/__tests__/components/BaseLayout/BaseLayout.test.js Outdated Show resolved Hide resolved
app/__tests__/components/BaseLayout/PageTitle.test.js Outdated Show resolved Hide resolved
app/__tests__/components/CenterLayout/Titles.test.js Outdated Show resolved Hide resolved
@dedenbangkit dedenbangkit merged commit 41baca5 into main Jul 2, 2023
3 of 4 checks passed
@dedenbangkit dedenbangkit deleted the feature/23-app-preference-page branch July 2, 2023 23:43
@ifirmawan ifirmawan linked an issue Jul 21, 2023 that may be closed by this pull request
App Preference Page #23
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wayangalihpratama wayangalihpratama wayangalihpratama left review comments

@dedenbangkit dedenbangkit dedenbangkit approved these changes

Assignees

@ifirmawan ifirmawan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App Preference Page
3 participants
@ifirmawan @dedenbangkit @wayangalihpratama