Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/31 geolocation question type #34

Merged
merged 31 commits into from
Jul 5, 2023
Merged

Feature/31 geolocation question type #34

merged 31 commits into from
Jul 5, 2023

Conversation

ifirmawan
Copy link
Contributor

@ifirmawan ifirmawan commented Jul 3, 2023 •
edited
Loading

TODO/DONE

  • Get the location
  • Map Preview
  • Unit tests
    • Library loc and expo-location
    • TypeGeo
    • MapView

@ifirmawan ifirmawan self-assigned this Jul 3, 2023
@ifirmawan ifirmawan marked this pull request as ready for review July 4, 2023 11:32
@ifirmawan
Copy link
Contributor Author

Hi mas @dedenbangkit I'll update the unit tests in a separate PR. Thank you

dedenbangkit
dedenbangkit requested changes Jul 4, 2023
View reviewed changes
Copy link
Member

@dedenbangkit dedenbangkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ifirmawan please don't use React.* directly

app/src/navigation/index.js Outdated Show resolved Hide resolved
app/src/pages/MapView.js Outdated Show resolved Hide resolved
app/src/pages/MapView.js Outdated Show resolved Hide resolved
app/src/pages/MapView.js Outdated Show resolved Hide resolved
app/src/pages/MapView.js Outdated Show resolved Hide resolved
app/src/pages/MapView.js Outdated Show resolved Hide resolved
app/src/form/FormContainer.js Outdated Show resolved Hide resolved
app/src/form/components/QuestionField.js Outdated Show resolved Hide resolved
app/src/form/fields/TypeGeo.js Outdated Show resolved Hide resolved
@dedenbangkit dedenbangkit merged commit 0bec7f0 into main Jul 5, 2023
4 checks passed
@dedenbangkit dedenbangkit deleted the feature/31-geolocation-question-type branch July 5, 2023 04:28
@ifirmawan ifirmawan linked an issue Jul 5, 2023 that may be closed by this pull request
Geolocation Question Type #31
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dedenbangkit dedenbangkit dedenbangkit approved these changes

Assignees

@ifirmawan ifirmawan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Geolocation Question Type
2 participants
@ifirmawan @dedenbangkit