Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1076 gps fix using global state #1123

Merged
merged 21 commits into from
Feb 6, 2024

Conversation

ifirmawan
Copy link
Contributor

@ifirmawan ifirmawan commented Feb 2, 2024

TODO/DONE

  • Store current location in global state and set it when the geo question doesn't have an answer after 1 minute
  • Add new settings: Geolocation

Manual Test

Normal use cases

  • Login, create a submission, submit, and sync
  • Update sync interval in settings

Geolocation use cases

  • Update geolocation timeout in a very short time, eg: 1 second. If the fetching location doesn't have a result then it should take from the global state (UserState.currentLocation)
  • Update accuracy level
  • Submit data after making some updates in the Geolocation settings

@ifirmawan ifirmawan self-assigned this Feb 2, 2024
@coveralls
Copy link

coveralls commented Feb 2, 2024

Coverage Status

coverage: 80.976% (-0.01%) from 80.987%
when pulling 6586e66 on feature/1076-gps-fix-using-global-state
into 78326de on develop.

@ifirmawan ifirmawan marked this pull request as ready for review February 5, 2024 09:59
@dedenbangkit dedenbangkit merged commit 52be05c into develop Feb 6, 2024
2 checks passed
@dedenbangkit dedenbangkit deleted the feature/1076-gps-fix-using-global-state branch February 6, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants