Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing Monitoring Data-point in the Manage Data Page #1178

Merged
merged 17 commits into from
Feb 19, 2024

Conversation

ifirmawan
Copy link
Contributor

@ifirmawan ifirmawan commented Feb 15, 2024

TODO/DONE

  • Backend modifications
  • Frontend modifications

Backend modifications

  • Add parent query param
  • Add a feature to include the count of children
  • Update related tests

Frontend modifications

  • Manage Page
  • Monitoring Details page

@ifirmawan ifirmawan self-assigned this Feb 15, 2024
@ifirmawan ifirmawan changed the title Feature/1166 monitoring list for manage data api BACKEND modifications - Showing Monitoring Datapoint Feb 15, 2024
@ifirmawan ifirmawan marked this pull request as ready for review February 15, 2024 09:44
@ifirmawan ifirmawan changed the title BACKEND modifications - Showing Monitoring Datapoint Showing Monitoring Data-point in the Manage Data Page Feb 19, 2024
@coveralls
Copy link

coveralls commented Feb 19, 2024

Coverage Status

coverage: 81.801% (+0.1%) from 81.666%
when pulling ff1d925 on feature/1166-monitoring-list-for-manage-data-api
into 7a503ff on develop.

Copy link
Member

@dedenbangkit dedenbangkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove expand button in the root (parent_id=null)
  • Include parent to the list of monitoring
  • Data with parent list

@dedenbangkit dedenbangkit merged commit d3f184a into develop Feb 19, 2024
4 checks passed
@dedenbangkit dedenbangkit deleted the feature/1166-monitoring-list-for-manage-data-api branch February 19, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants