-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/832 download administration excel list #833
Merged
dedenbangkit
merged 48 commits into
develop
from
feature/832-download-administration-excel-list
Jan 29, 2024
Merged
Feature/832 download administration excel list #833
dedenbangkit
merged 48 commits into
develop
from
feature/832-download-administration-excel-list
Jan 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
dedenbangkit
requested changes
Jan 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ifirmawan, here's my review:
- We need to create a new endpoint that sends a new job to the worker. This is necessary to prevent users from downloading excessive amounts of data, which could lead to memory leaks.
- In the front-end, we should implement a checkbox to allow users to choose between downloading a template with pre-filled data or without it. Additionally, we need a filter to selectively choose the administration. If the user opts for a template without pre-filled data, the download should start immediately. Otherwise, the process should be the same as in the Data Submission, where the user is redirected to the download list page.
dedenbangkit
approved these changes
Jan 29, 2024
dedenbangkit
deleted the
feature/832-download-administration-excel-list
branch
January 29, 2024 17:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO/DONE