Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/832 download administration excel list #833

Merged
merged 48 commits into from
Jan 29, 2024

Conversation

ifirmawan
Copy link
Contributor

@ifirmawan ifirmawan commented Jan 3, 2024

TODO/DONE

  • Prefilled administrations list based on selected adm level
  • Add filter level in Download section - Bulk Upload page
  • Add a checkbox to allow users to choose between with(out) pre-filled data
  • Add new endpoint: download prefilled with worker
  • Add Administration Selector on Administration Download

@ifirmawan ifirmawan self-assigned this Jan 3, 2024
@ifirmawan ifirmawan linked an issue Jan 3, 2024 that may be closed by this pull request
1 task
@coveralls
Copy link

coveralls commented Jan 3, 2024

Coverage Status

coverage: 81.001% (-0.6%) from 81.575%
when pulling 1a51cee on feature/832-download-administration-excel-list
into c8b7c33 on develop.

@ifirmawan ifirmawan marked this pull request as ready for review January 3, 2024 14:11
Copy link
Member

@dedenbangkit dedenbangkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ifirmawan, here's my review:

  1. We need to create a new endpoint that sends a new job to the worker. This is necessary to prevent users from downloading excessive amounts of data, which could lead to memory leaks.
  2. In the front-end, we should implement a checkbox to allow users to choose between downloading a template with pre-filled data or without it. Additionally, we need a filter to selectively choose the administration. If the user opts for a template without pre-filled data, the download should start immediately. Otherwise, the process should be the same as in the Data Submission, where the user is redirected to the download list page.

@dedenbangkit dedenbangkit merged commit d79025b into develop Jan 29, 2024
4 checks passed
@dedenbangkit dedenbangkit deleted the feature/832-download-administration-excel-list branch January 29, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download Administration Excel List
3 participants