Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

akyuu: move init() to constructor #38

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

akyuu: move init() to constructor #38

wants to merge 1 commit into from

Conversation

XadillaX
Copy link
Contributor

@XadillaX XadillaX commented Oct 30, 2017 •
edited

Fixes: #37

Checklist
Affected core submodule(s)

express

DuanPengfei pushed a commit that referenced this pull request Mar 2, 2018
@XadillaX @DuanPengfei
akyuu: move init() to constructor
146512f 
Fixes: #37

PR-URL: #38
Reviewd-By: DuanPengfei <duanpengfei1993@qq.com>
DuanPengfei added a commit that referenced this pull request Mar 2, 2018
@DuanPengfei
2018-03-02, Version 0.5.1
6c5c5aa 
Notable changes

* **Core**
  * Fix can't set template root and engine before `init()`.

PR-URL: #38
@DuanPengfei DuanPengfei mentioned this pull request Mar 2, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@summerbabybiu summerbabybiu summerbabybiu approved these changes

@DuanPengfei DuanPengfei Awaiting requested review from DuanPengfei

Assignees

@DuanPengfei DuanPengfei

Labels
confirmed-bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't set template root and engine before init()
3 participants
@XadillaX @summerbabybiu @DuanPengfei