Don't discard error code from rustix::fallocate #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… around the differences between fallocate/posix_fallocate, specifically whether the error code is returned directly or in errno.
|
Thank you very much! |
|
When you get the chance, would it be possible to publish a new version to crates.io? Since this is just a bugfix and you are still on 0.X.Y I think a minor bump would be fine. |
|
Hi, the new version published. |
This was referenced Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustix already abstracts around the differences between
fallocateandposix_fallocate, specifically whether the error code is returned directly or through errno.This will fix
fs4::FileExt::allocateon platforms that do not havefallocate(e.g. FreeBSD), but Linux behavior will stay the same as before