Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatting check #22

Merged
merged 2 commits into from
May 27, 2024
Merged

Fix formatting check #22

merged 2 commits into from
May 27, 2024

Conversation

thirteenowls
Copy link

Like tokio, fs4 uses macros to avoid copy-pasting #[cfg] attributes. This prevents cargo fmt from seeing modules gated using those macros.
This PR implements the same workaround[1][2] as tokio, which is to run rustfmt directly on all .rs files.

@thirteenowls
Fix formatting check
289a5dc 
`cargo fmt` cannot see modules declared using macros.
@thirteenowls
fmt
0951c68
al8n
al8n approved these changes May 27, 2024
View reviewed changes
Copy link
Owner

@al8n al8n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@al8n al8n merged commit 9c4565d into al8n:master May 27, 2024
6 of 7 checks passed
@thirteenowls thirteenowls deleted the fix-fmt branch May 27, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@al8n al8n al8n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thirteenowls @al8n