Cancel AsyncTasks execution when onPause Activity happens

alabeduarte · Jul 22, 2016 · 740fcab · 740fcab
1 parent 7757d08
commit 740fcab
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 4 deletions.
diff --git a/app/build.gradle b/app/build.gradle
@@ -40,7 +40,7 @@ dependencies {
   compile fileTree(dir: 'libs', include: ['*.jar'])
   compile 'com.android.support:appcompat-v7:21.+'
 
-  compile 'com.github.alabeduarte:retryableasynctask:0.0.5'
+  compile 'com.github.alabeduarte:retryableasynctask:0.1.0'
 
   compile 'org.roboguice:roboguice:3.+'
   provided 'org.roboguice:roboblender:3.+'

diff --git a/app/src/main/java/com/mypodcasts/MyPodcastsActivity.java b/app/src/main/java/com/mypodcasts/MyPodcastsActivity.java
@@ -40,6 +40,7 @@ public class MyPodcastsActivity extends RoboActionBarActivity {
 
   @Inject
   private UserFeedsRepository userFeedsRepository;
+  private FeedsAsyncTask feedsAsyncTask;
 
   @Override
   protected void onCreate(Bundle savedInstanceState) {
@@ -59,7 +60,16 @@ public void onItemClick(AdapterView<?> parent, View view, int position, long id)
       }
     });
 
-    new FeedsAsyncTask(this).execute();
+    feedsAsyncTask = new FeedsAsyncTask(this);
+
+    feedsAsyncTask.execute();
+  }
+
+  @Override
+  protected void onPause() {
+    super.onPause();
+
+    feedsAsyncTask.cancel();
   }
 
   @Override

diff --git a/app/src/main/java/com/mypodcasts/episodes/EpisodeFeedsActivity.java b/app/src/main/java/com/mypodcasts/episodes/EpisodeFeedsActivity.java
@@ -32,14 +32,24 @@ public class EpisodeFeedsActivity extends MyPodcastsActivity {
 
   @Inject
   private UserFeedsRepository userFeedsRepository;
+  private FeedEpisodesAsyncTask feedEpisodesAsyncTask;
 
   @Override
   protected void onCreate(Bundle savedInstanceState) {
     super.onCreate(savedInstanceState);
 
     Feed feed = (Feed) getIntent().getSerializableExtra(Feed.class.toString());
 
-    new FeedEpisodesAsyncTask(this, feed).execute();
+    feedEpisodesAsyncTask = new FeedEpisodesAsyncTask(this, feed);
+
+    feedEpisodesAsyncTask.execute();
+  }
+
+  @Override
+  protected void onPause() {
+    super.onPause();
+
+    feedEpisodesAsyncTask.cancel();
   }
 
   @Override

diff --git a/app/src/main/java/com/mypodcasts/episodes/latestepisodes/LatestEpisodesActivity.java b/app/src/main/java/com/mypodcasts/episodes/latestepisodes/LatestEpisodesActivity.java
@@ -35,12 +35,22 @@ public class LatestEpisodesActivity extends MyPodcastsActivity {
 
   @Inject
   private UserLatestEpisodesRepository userLatestEpisodesRepository;
+  private LatestEpisodesAsyncTask latestEpisodesAsyncTask;
 
   @Override
   protected void onCreate(Bundle savedInstanceState) {
     super.onCreate(savedInstanceState);
 
-    new LatestEpisodesAsyncTask(this).execute();
+    latestEpisodesAsyncTask = new LatestEpisodesAsyncTask(this);
+
+    latestEpisodesAsyncTask.execute();
+  }
+
+  @Override
+  protected void onPause() {
+    super.onPause();
+
+    latestEpisodesAsyncTask.cancel();
   }
 
   @Override