[build] Move assignment out of condition (clang warning)

alacarte-maps · Dec 4, 2013 · 6c05339 · 6c05339
1 parent c373b8f
commit 6c05339
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/utils/cached_string.cpp b/src/utils/cached_string.cpp
@@ -439,8 +439,8 @@ void MaybeCachedString::assign( const string& str )
 void MaybeCachedString::assign( const MaybeCachedString& other )
 {
 	reset();
-	if(cached = other.cached)
-	{
+	cached = other.cached;
+	if (cached) {
 		internalString = other.internalString;
 	} else {
 		internalString = new StringStorageElement(*other.internalString);
@@ -552,4 +552,4 @@ void MaybeCachedString::reset()
 bool MaybeCachedString::isCached() const
 {
 	return cached;
-}
+}