Update Glutin

[rigtorp]

This version of glutin doesn't compile on Windows 10:

[dependencies.glutin]
git = "https://github.com/jwilm/glutin"
rev = "af7fe340bd4a2af53ea521defcb4f377cdc588cf"

Upstream glutin 0.7.1 compiles fine:

glutin = "0.7.1"

This is blocking windows support.

[insunaa]

Have you tried compiling alacritty with glutin 0.7.1? I'm curious what your results are

[jwilm]

Have you tried compiling alacritty with glutin 0.7.1? I'm curious what your results are

This will not work. Alacritty is on a fork of glutin that has a very different Event::KeyboardInput variant:

• Includes Mods which are the modifier keys as provided by the XEvent or equivalent on other platforms
• Includes the UTF-8 string generated by the input sequence. This is normally provided in a separate event, but Alacritty needs both at once to either run a key binding or forward the string to the pty.

[rigtorp]

@jwilm Does it make sense to upstream your changes to glutin?

[jwilm]

Very much so. I was hoping to make these changes for windows and wayland before opening a PR, but maybe they would be accepted separately.

[jwilm]

Renamed this issue to suggest an action. We need to reapply my patches on top of what's now two projects (winit + glutin), upstream them, and then update Alacritty's dependencies.

[rigtorp]

Opened this issue rust-windowing/winit#108 to see if upstream is willing to accept these improvements.

[rigtorp]

Submitted PR rust-windowing/winit#112 to add keyboard modifiers to winit keyboard event.

[emersion]

rust-windowing/winit#112 has been merged

[rigtorp]

@emersion Now we need to update glutin to this newer version of winit

[mystal]

Looks like with the merge of rust-windowing/glutin#864 glutin's master branch is now using the latest winit. One step closer!

[emersion]

Linking a related PR: #554

[jonhoo]

I wonder if this would also fix #148...

[jwilm]

It might; there's been a lot of work in this area in winit lately. There's also someone waiting to contribute some fixes for IME support which might be the fix needed for compose key.

[jwilm]

Glutin/winit API churn is really high right now, and the latest candidate branch has some bugs. There's a new WIP to update current Glutin API to winit 0.7.1, and hopefully we can get on that.