Handle CSI command J3 (Clear saved lines) #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, and for the thorough explanation! Would you mind putting that info into the commit message so it's visible in git log and blame? |
|
Sure! |
Xterm supports an extension to the CSI command `Erase in Display (ED)`, under the command number 3. This command is used to clear the scrollback buffer - e.g. anything not visible on the screen. Since scrollback is not part of alacritty, the handler for this command currently does nothing. If at some point scrollback is implemented, the corresponding `match` arm can be modified to properly handle this. For an example of a program which uses this command, run the `clear` command (using ncurses 6.0). In a supported terminal such as `gnome-terminal`, this will clear anything off of the screen from the scrollback buffer. Before this change, `alacritty` would generate an `Unhandled CSI` message.
|
@jwilm I've modified the commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xterm supports an extension to the CSI command Erase in Display (ED), under the command number 3. This command is used to clear the scrollback buffer - e.g. anything not visible on the screen.
Since scrollback may not be added to alacritty, I've made the handler for this command do nothing. If at some point scrollback is implemented, the corresponding
matcharm can be modified to properly handle this.For an example of a program which uses this command, run the
clearcommand (using ncurses 6.0). In a supported terminal such asgnome-terminal, this will clear anything off of the screen from the scrollback buffer. In the current alacrittymaster, this will generate anUnhandled CSImessage.