Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation on ARM/AARCH64 #60

Merged
merged 2 commits into from
Jan 6, 2017
Merged

Fix compilation on ARM/AARCH64 #60

merged 2 commits into from
Jan 6, 2017

Conversation

MagaTailor
Copy link
Contributor

@MagaTailor MagaTailor commented Jan 5, 2017

error[E0308]: mismatched types
    --> src/renderer/mod.rs:1042:41
     |
1042 |             gl::ShaderSource(shader, 1, &(source.as_ptr() as *const i8), len.as_ptr());
     |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected u8, found i8
     |
     = help: here are some functions which might fulfill your needs:
 - .offset(...)
 - .wrapping_offset(...)

error[E0308]: mismatched types
   --> src/tty.rs:174:43
    |
174 |         libc::getpwuid_r(uid, &mut entry, buf.as_mut_ptr(), buf.len(), &mut res)
    |                                           ^^^^^^^^^^^^^^^^ expected u8, found i8
    |
    = help: here are some functions which might fulfill your needs:
 - .offset(...)
 - .wrapping_offset(...)

Not exactly cross-platform, eh?

rust-lang/rust#29867

@jwilm
Copy link
Contributor

jwilm commented Jan 5, 2017

Thanks for the fixes! Any thoughts about how we might keep ARM builds from regressing?

@MagaTailor
Copy link
Contributor Author

As we're talking about fallout from that particular breaking change, I'd say avoid explicit stuff like Vec<*const i8> or as_ptr() as *const i8, etc.

@jwilm
Copy link
Contributor

jwilm commented Jan 5, 2017

Er, I was thinking more from a CI perspective. Your advice it noted, though.

@MagaTailor
Copy link
Contributor Author

MagaTailor commented Jan 5, 2017 via email

@MagaTailor MagaTailor changed the title Fix compilation on ARM Fix compilation on ARM/AARCH64 Jan 5, 2017
@jwilm
Copy link
Contributor

jwilm commented Jan 6, 2017

Thanks for the PR. I'll file an issue about getting CI added.

@jwilm jwilm merged commit 41f7fae into alacritty:master Jan 6, 2017
@MagaTailor
Copy link
Contributor Author

Great, please consider adding GLES (or at least OpenGL 2.0) support to make alacritty runnable on a typical ARM system. Thanks!

chrisduerr pushed a commit to chrisduerr/alacritty that referenced this pull request Apr 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants