add support for X input method #691
Conversation
There was a problem hiding this comment.
This looks great! Thanks for all of your work figuring out what needs to be done for IME support with XIM and implementing a PR. Also thanks for the patience on Glutin/winit updates.
I've commented on a couple of areas where some refactorings could improve maintainability. This PR can be merged once those are resolved.
src/main.rs
Outdated
| padding_y: py, ..} = *terminal.size_info(); | ||
| let nspot_y = (py + (row + 1) as f32 * ch) as i16; | ||
| let nspot_x = (px + col as f32 * cw) as i16; | ||
| display.window().send_xim_spot(nspot_x, nspot_y); |
There was a problem hiding this comment.
Can we move all of this logic into a method on Display like update_ime_position(&terminal)?
src/term/mod.rs
Outdated
| @@ -640,7 +640,7 @@ pub struct Term { | |||
| alt: bool, | |||
|
|
|||
| /// The cursor | |||
| cursor: Cursor, | |||
| pub cursor: Cursor, | |||
There was a problem hiding this comment.
Rather than making cursor pub, I think we should add an accessor that returns a read-only ref. Something like
fn cursor(&self) -> &Cursor {}
src/window.rs
Outdated
| @@ -183,6 +183,23 @@ impl Window { | |||
| title: &str | |||
| ) -> Result<Window> { | |||
| let event_loop = EventsLoop::new(); | |||
|
|
|||
| #[cfg(any(target_os = "linux", target_os = "freebsd", | |||
There was a problem hiding this comment.
This block should be moved into a method like platform_window_init so that there's not conditionally compiled code in the method body.
|
Thanks for the changes; waiting for CI |
Reapply the changes to the latest master (#658).