Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "no-throw-literal" #37

Merged
merged 3 commits into from
Feb 25, 2019
Merged

Add "no-throw-literal" #37

merged 3 commits into from
Feb 25, 2019

Conversation

g-plane
Copy link
Collaborator

@g-plane g-plane commented Feb 25, 2019

close #31

aladdin-add
aladdin-add approved these changes Feb 25, 2019
View reviewed changes
Copy link
Owner

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

non-bloking: 最好能补充一些测试 e.g.

throw 0;
throw "";
throw foo;

@g-plane
Copy link
Collaborator Author

g-plane commented Feb 25, 2019

throw foo 是不需要的。

@g-plane g-plane merged commit 803c818 into master Feb 25, 2019
@g-plane g-plane deleted the no-throw-literal branch February 25, 2019 07:26
@aladdin-add
Copy link
Owner

valid case.. 😄

@aladdin-add aladdin-add mentioned this pull request Feb 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aladdin-add aladdin-add aladdin-add approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-throw-literal
2 participants
@g-plane @aladdin-add