-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: add "no-unused-vars" #41
Conversation
tests/lib/rules/no-unused-vars.js
Outdated
valid: [ | ||
{ | ||
code: "import 'm'", | ||
parserOptions: { sourceType: "module" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is required to use {ecmaVersion: 6}
in eslint v6 (not published yet).
also, you can use const ruleTester = new RuleTester({parserOpitons: {...}});
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code looks good to me.
can you add some more tests like:
var undef; // => autofix
var t = `foo-${bar()}`; // no-autofix
var a = b = c; // either
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Fixes #33 .