Skip to content

Commit

Permalink
Add caution notes on cache building (#1)
Browse files Browse the repository at this point in the history
  • Loading branch information
alaindet committed Feb 7, 2021
1 parent ddd6e14 commit 2bc8b30
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ Offline Video Player is admittedly a specific solution to a specific problem, so

- It only works with `.mp4` files
- Changing any `.mp4` file in the `/videos` folder could disrupt the saved progress
- Initial build of the cache can take from a few seconds **up to several minutes** depending on your machine and the number of videos; however, this should only happens once, the first time you run the app
- Saved progress as well as cache is persisted as JSON files, no database involved
- Being served locally, some best practices were skipped, i.e.: most operations are synchronous
- Zero builds: frontend is not minified, backend only implements the basic CommonJS syntax
Expand Down
2 changes: 1 addition & 1 deletion src/services/videos-cache.service.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ const build = async () => {
`));
}

log.write('Start building videos cache');
log.write('Start building videos cache (please wait)');

const timeTaken = await asyncRecordTimeInSeconds(async () => {
const files = getVideoPaths(paths.VIDEOS);
Expand Down

0 comments on commit 2bc8b30

Please sign in to comment.