Make filter icon animation smoother #1290
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riksu9000
force-pushed
the
smoother-animation
branch
from
328dea8
to
cf21ff1
Compare
alainm23
requested changes
May 12, 2024
Riksu9000
force-pushed
the
smoother-animation
branch
from
cf21ff1
to
48086a2
Compare
|
I noticed an issue where the selected style is not always applied. I'll take another look tomorrow. |
With these changes, the animation won't stop abruptly. Previously clicking on the filter multiple times or clicking on another filter while the animation is playing can cause the animation to end abruptly. Now the animation always plays to the end before it can start again. The animation length is 700ms, so the timeout was made shorter.
Riksu9000
force-pushed
the
smoother-animation
branch
from
48086a2
to
ec2a45f
Compare
|
Never mind, it was pretty simple. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes, the animation won't stop abruptly.
Previously clicking on the filter multiple times or clicking on another filter while the animation is playing can cause the animation to end abruptly. Now the animation always plays to the end before it can start again.
The animation length is 700ms, so the timeout was made shorter.