Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to skip plugin execution #129

Conversation

Aloren
Copy link
Contributor

@Aloren Aloren commented Feb 26, 2019

No description provided.

@coveralls
Copy link

coveralls commented Feb 26, 2019

Coverage Status

Coverage remained the same at 86.976% when pulling 5a96aab on Aloren:feature/add-ability-to-skip-execution into 08e214b on alainsahli:master.

@Aloren Aloren mentioned this pull request Feb 26, 2019
@cstettler
Copy link
Member

Thank you @Aloren for this contribution. While I can see the use case for skipping the Maven plugin execution (conditional build steps), I am not sure about adding the same support for the Docker-based publishing.

In fact, your current implementation would not use the provided SKIP environment variable in the Docker-based publishing at all, as under the hood, the Docker-based publishing does not use the Maven Mojo, but the AsciidocConfluencePublisherCommandLineClient.

Anyway, if you agree with me, I would suggest to restrict the skip parameter to the Maven plugin execution only.

@Aloren
Copy link
Contributor Author

Aloren commented Feb 26, 2019

I am not sure about adding the same support for the Docker-based publishing.

this was my initial thought as well. i will remove it, added it just in case you would like to have all parameters to be available in container as well.

Docker-based publishing does not use the Maven Mojo

Sorry, my bad. :(

Anyway, if you agree with me, I would suggest to restrict the skip parameter to the Maven plugin execution only.

agree, no problems

@Aloren Aloren force-pushed the feature/add-ability-to-skip-execution branch from 11ee798 to e4101fb Compare February 26, 2019 21:19
@Aloren Aloren force-pushed the feature/add-ability-to-skip-execution branch from e4101fb to 5a96aab Compare February 26, 2019 21:20
@Aloren
Copy link
Contributor Author

Aloren commented Feb 26, 2019

rebased onto master and fixed

@cstettler cstettler changed the base branch from master to pr/aloren/feature/add-ability-to-skip-execution February 26, 2019 21:23
@cstettler
Copy link
Member

Merging PR to pr/aloren/feature/add-ability-to-skip-execution for integration into master

@cstettler cstettler merged commit b421da6 into confluence-publisher:pr/aloren/feature/add-ability-to-skip-execution Feb 26, 2019
@Aloren Aloren deleted the feature/add-ability-to-skip-execution branch May 7, 2020 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants