Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration handling #24

Closed
qrrcnaxne opened this issue Jul 8, 2022 · 2 comments
Closed

Configuration handling #24

qrrcnaxne opened this issue Jul 8, 2022 · 2 comments
Labels
question Further information is requested

Comments

@qrrcnaxne
Copy link

I have a simple question about one of the code decisions in this project. I see you've chosen to not use the golang viper library for handling configuration and have a custom implementation with yaml library. I was wondering if there was a specific reason for this decision? Viper is compatible with cobra, written by the same author, so it would've been a good option?

@qrrcnaxne qrrcnaxne added the question Further information is requested label Jul 8, 2022
@alajmo
Copy link
Owner

alajmo commented Jul 11, 2022

I think I looked at it at the beginning (actually for mani) but opted for my own since sake has more complex logic than a simple key-value config (supports nested config files, references to other objects, conditional specifications, etc.). So all of the features viper offers, it's easier for me to implement on my own, rather than find a way to use some of Viper's features.
With that said, I might in the future take another look at Viper for sake, and it seems like a good compliment to Cobra for certain projects.

@qrrcnaxne
Copy link
Author

Hey yepp. Thanks a lot for answering. I really like the project. I've dabbled a little in something very similar but now I switched to using this sake. Great project!

@alajmo alajmo closed this as completed Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants