Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency ws to 7.4.6 [SECURITY] #294

Merged
merged 1 commit into from Jun 9, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 6, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change
ws 7.3.0 -> 7.4.6

GitHub Vulnerability Alerts

CVE-2021-32640

Impact

A specially crafted value of the Sec-Websocket-Protocol header can be used to significantly slow down a ws server.

Proof of concept

for (const length of [1000, 2000, 4000, 8000, 16000, 32000]) {
  const value = 'b' + ' '.repeat(length) + 'x';
  const start = process.hrtime.bigint();

  value.trim().split(/ *, */);

  const end = process.hrtime.bigint();

  console.log('length = %d, time = %f ns', length, end - start);
}

Patches

The vulnerability was fixed in ws@7.4.6 (websockets/ws@00c425e) and backported to ws@6.2.2 (websockets/ws@78c676d) and ws@5.2.3 (websockets/ws@76d47c1).

Workarounds

In vulnerable versions of ws, the issue can be mitigated by reducing the maximum allowed length of the request headers using the --max-http-header-size=size and/or the maxHeaderSize options.

Credits

The vulnerability was responsibly disclosed along with a fix in private by Robert McLaughlin from University of California, Santa Barbara.


Configuration

📅 Schedule: "" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the renovate label Jun 6, 2021
@codecov
Copy link

codecov bot commented Jun 6, 2021

Codecov Report

Merging #294 (a4ca1a7) into master (39f2dc8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #294   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          131       131           
=========================================
  Hits           131       131           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39f2dc8...a4ca1a7. Read the comment docs.

@alallier alallier merged commit 1b549df into master Jun 9, 2021
@alallier alallier deleted the renovate/npm-ws-vulnerability branch June 9, 2021 18:53
alallier added a commit that referenced this pull request Jun 10, 2021
* CI Updates
  * Dropped Node 10.x and added 16.x from CI - See: #298
  * Update actions/checkout action to v2 - See: #276
  * Update actions/setup-node action to v2 - #282
* Dependency Updates
  * Update commander from ~6.1.0 to ~7.2.0 - See: #283
  * Update url-parse from ~1.4.4 to ~1.5.0 - See: #291
  * Update open from ^7.0.0 to ^8.0.0 - See: https://github.com/alallier/reload/pull/292/files
  * Update ws from ~7.3.0 to ~7.4.6 - See: #294
  * Update sinon from 9.1.0 to 11.1.1 - See: https://github.com/alallier/reload/pull/295/files
  * Update mocha from 8.4.0 to 9.0.0 - See: https://github.com/alallier/reload/pull/297/files
  * Update downstream y18n from 4.0.0 to 4.0.1 - See: #288
@alallier alallier mentioned this pull request Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants