Replace supports_bounded_execution with supports_retract_batch #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
With the changes in the target PR,
supports_retract_batch
method is introduced to theAccumulator
trait. With the introduction ofsupports_retract_batch
method,supports_bounded_execution
method is no longer necessary for theAggregateExpr
trait. (Similar to the case we have movesupports_bounded_execution
trait fromBuiltinWindowFunctionExpr
toPartitionEvalautor
trait.)This PR removes
supports_bounded_execution
method fromAggregateExpr
and moves its functionality tosupports_retract_batch
method in the Accumulator` trait for existing accumulators.What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?