Fix debugpy CI issue; Accept pytorch 2 for python >3.7 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luciaquirke
changed the title
luciaquirke
force-pushed
the
luciaq-bump-pytorch
branch
from
e7251bf
to
25769eb
Compare
luciaquirke
changed the title
luciaquirke
changed the title
Closed
|
Thanks for the PR! |
|
@alan-cooney could we please do a release with this update? Keen to use it 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal
Accept pytorch version 2 when python >3.7.
Updating this also made me realise that this repo is affected by microsoft/debugpy#1246, so I have pinned poetry to fix.
Motivation
I want to support pytorch version 2 in TransformerLens so I can support MPS (M1 GPU acceleration) but can't because of the range restriction on CircuitsVis's pytorch dependency.
Pitch
Pytorch is pinned to ^1.1.
In Poetry dependency specification, the caret symbol
^prevents the left-most non-zero digit in the dependency version number from being modified. In our case this prevents users from updating to PyTorch 2.0. This limitation will restrict CircuitsVis' user base, as users will want to use both PyTorch 2.0 and CircuitsVis in their projects. There's a related discussion in TransformerLens.Pytorch 2 requires python >3.7 so we can only bump the dependency for users in this version range.
Checklist