Yet another attempt at fixing frontend-docker

alan-turing-institute · Apr 22, 2022 · 29f11fe · 29f11fe
1 parent 881cc02
commit 29f11fe
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/frontend-docker.yaml b/.github/workflows/frontend-docker.yaml
@@ -19,11 +19,11 @@ jobs:
         if: ${{ github.ref == 'refs/heads/main' }}
         working-directory: frontend
         run: |
-          docker build -t turingassuranceplatform/eap_frontend:main --build-arg REACT_APP_BASE_URL="https://turing-assuranceplatform-backend.azurewebsites.net/api" -f Dockerfile .
+          docker build -t turingassuranceplatform/eap_frontend:main -f Dockerfile .
           docker push turingassuranceplatform/eap_frontend:main
       - name: 'Build dev'
         if: ${{ github.ref == 'refs/heads/dev' }}
         working-directory: frontend
         run: |
-          docker build -t turingassuranceplatform/eap_frontend:dev --build-arg REACT_APP_BASE_URL="https://turing-assuranceplatform-backend.azurewebsites.net/api" -f Dockerfile .
+          docker build -t turingassuranceplatform/eap_frontend:dev -f Dockerfile .
           docker push turingassuranceplatform/eap_frontend:dev
diff --git a/frontend/Dockerfile b/frontend/Dockerfile
@@ -1,4 +1,5 @@
 FROM node:16.14.2-slim
+ENV REACT_APP_BASE_URL="https://turing-assuranceplatform-backend.azurewebsites.net/api"
 COPY . /frontend
 WORKDIR /frontend
 RUN npm install