New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/76 edit view #103
Merged
Merged
Feature/76 edit view #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add dockerfile for frontend
… view in edit mode for that user
Pull Request Test Coverage Report for Build 2207266877
💛 - Coveralls |
Pull Request Test Coverage Report for Build 2219301662
💛 - Coveralls |
mhauru
approved these changes
Apr 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Nice and elegant and robust seeming. I had one question about possible race conditions, can be merged as-is though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main
.lock_uuid
charfield to AssuranceCase model (replacing boolean fieldeditable
).CaseContainer.js
generate a new uuid and store it in both the state and the browser's sessionData (so it is maintained with "refresh").lock_uuid
is currently null,lock_uuid
is currently this user's session_idlock_uuid
is a non-null value that is not the current session_idlock_uuid
will be reset to null if the browser tab is closed.