Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc final items #149

Merged
merged 6 commits into from May 31, 2022
Merged

Misc final items #149

merged 6 commits into from May 31, 2022

Conversation

mhauru
Copy link
Collaborator

@mhauru mhauru commented May 31, 2022

Fix some eslint warnings, reoder navbar links, fix requirements.txts.

@mhauru mhauru requested a review from nbarlowATI May 31, 2022 09:59
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2414167140

  • 12 of 13 (92.31%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 81.135%
Changes Missing Coverage Covered Lines Changed/Added Lines %
eap_backend/eap_api/models.py 0 1 0.0%
Totals Coverage Status
Change from base Build 2413789301: 0.1%
Covered Lines: 929
Relevant Lines: 1145
💛 - Coveralls

nbarlowATI
nbarlowATI approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@nbarlowATI nbarlowATI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, all looks good!

@nbarlowATI nbarlowATI merged commit 9c3abf3 into dev May 31, 2022
@nbarlowATI nbarlowATI deleted the misc-final-items branch May 31, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbarlowATI nbarlowATI nbarlowATI approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mhauru @coveralls @nbarlowATI