Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/backend style action #63

Merged
merged 7 commits into from
Mar 23, 2022
Merged

Feature/backend style action #63

merged 7 commits into from
Mar 23, 2022

Conversation

nbarlowATI
Copy link
Member

Added a github action to run flake8 on the backend python code.
Also fixed some issues highlighted by flake8 (mostly unused imports).

@nbarlowATI nbarlowATI requested a review from mhauru March 22, 2022 18:11
@coveralls
Copy link

coveralls commented Mar 22, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2024092326

  • 3 of 4 (75.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.07%) to 90.534%
Changes Missing Coverage Covered Lines Changed/Added Lines %
eap_backend/eap_backend/settings.py 0 1 0.0%
Totals Coverage Status
Change from base Build 2022865940: 1.07%
Covered Lines: 966
Relevant Lines: 1067
💛 - Coveralls

mhauru
mhauru approved these changes Mar 23, 2022
View reviewed changes
Copy link
Collaborator

@mhauru mhauru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@nbarlowATI nbarlowATI merged commit 96e52be into main Mar 23, 2022
@nbarlowATI nbarlowATI deleted the feature/backen-style-action branch March 23, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhauru mhauru mhauru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nbarlowATI @coveralls @mhauru