Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import/export #68

Merged
merged 5 commits into from Mar 28, 2022
Merged

Import/export #68

merged 5 commits into from Mar 28, 2022

Conversation

mhauru
Copy link
Collaborator

@mhauru mhauru commented Mar 24, 2022

Adds a button in CaseContainer that exports the case as a JSON file, and a button in CaseCreator that can be used to import that same file to create a copy of the case.

Builds on #65, so may be better to merge that first, to see a diff with only the import/export related code.

@mhauru
Copy link
Collaborator Author

mhauru commented Mar 24, 2022

https://www.githubstatus.com/ says that triggering actions is down/slow. Assuming they pass once they run, this is ready for review.

@mhauru mhauru requested a review from nbarlowATI March 24, 2022 15:33
@mhauru
Copy link
Collaborator Author

mhauru commented Mar 24, 2022

Oh, meant to add a note in the source code: The top right corner of CaseContainer is getting pretty crowded and I'm starting to regret removing the side panel. But maybe sort out where the buttons should be once we settle down a bit with adding more of them?

@coveralls
Copy link

coveralls commented Mar 24, 2022

Pull Request Test Coverage Report for Build 2035246442

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.9%) to 88.639%

Totals Coverage Status
Change from base Build 2027395551: -1.9%
Covered Lines: 1576
Relevant Lines: 1778

💛 - Coveralls

Copy link
Member

@nbarlowATI nbarlowATI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly (once I figured out I needed to redo npm install to get file-saver).

Yep, would be good to get feedback from users about the best way to deal with proliferation of buttons on the top right, but for now I think this is

@nbarlowATI nbarlowATI merged commit 7332d73 into main Mar 28, 2022
@mhauru mhauru deleted the import-export branch April 1, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants