Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce item levels #86

Merged
merged 4 commits into from Apr 12, 2022
Merged

Introduce item levels #86

merged 4 commits into from Apr 12, 2022

Conversation

mhauru
Copy link
Collaborator

@mhauru mhauru commented Apr 1, 2022

@nbarlowATI, I started working on adding a level field to all the case items. Restructuring models.py a bit in the process too, and trying to prepare the ground for more many-to-many parent fields and multiple types of parents. This is work in progress, and I'm making a PR draft just to have a place where to discuss this stuff. Feel free to push to this branch if you work on the same feature.

EDIT: No longer work in progress. This adds levels (only) to property claims, makes it possible for claims to have claims as parents, adds a frontend button for creating such subclaims, and reorganises some things in the process. Oh, and adds created_date to all items.

@coveralls
Copy link

coveralls commented Apr 5, 2022

Pull Request Test Coverage Report for Build 2097414184

  • 40 of 49 (81.63%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-90.5%) to 0.0%

Changes Missing Coverage Covered Lines Changed/Added Lines %
eap_backend/eap_api/models.py 29 31 93.55%
eap_backend/eap_api/views.py 2 9 22.22%
Totals Coverage Status
Change from base Build 2078504785: -90.5%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@mhauru mhauru changed the title Introduce item levels, WIP Introduce item levels Apr 5, 2022
@mhauru mhauru marked this pull request as ready for review April 5, 2022 16:27
@mhauru mhauru requested a review from nbarlowATI April 5, 2022 16:27
Copy link
Member

@nbarlowATI nbarlowATI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent - even if we don't end up needing to use Levels, there are still some super-useful changes here - I like the idea of the CaseItem abstract base class.

@nbarlowATI nbarlowATI merged commit 6466b37 into dev Apr 12, 2022
@nbarlowATI nbarlowATI deleted the levels branch April 12, 2022 16:07
@mhauru
Copy link
Collaborator Author

mhauru commented Apr 13, 2022

Ah yes, I already kinda forgot that we concluded that levels are probably unnecessary after all. I could make a PR removing them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants