Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix197b #201

Merged
merged 2 commits into from Aug 5, 2019
Merged

Fix197b #201

merged 2 commits into from Aug 5, 2019

Conversation

tlienart
Copy link
Collaborator

@tlienart tlienart commented Aug 5, 2019

  • removes the Parameters dep
  • brings back the kw constructors

(actually works; previous pr attempt had other commits mixed in and it became messy)

@codecov-io
Copy link

codecov-io commented Aug 5, 2019

Codecov Report

Merging #201 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #201     +/-   ##
=========================================
+ Coverage   71.47%   71.57%   +0.1%     
=========================================
  Files          19       19             
  Lines        1413     1418      +5     
=========================================
+ Hits         1010     1015      +5     
  Misses        403      403
Impacted Files Coverage Δ
src/MLJ.jl 100% <ø> (ø) ⬆️
src/resampling.jl 81.3% <100%> (+0.53%) ⬆️
src/tuning.jl 72.38% <100%> (+0.53%) ⬆️
src/composites.jl 84.02% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aea48c...24ec4b7. Read the comment docs.

@ablaom ablaom closed this Aug 5, 2019
@ablaom ablaom reopened this Aug 5, 2019
@ablaom ablaom merged commit b05d770 into master Aug 5, 2019
@ablaom ablaom deleted the fix197b branch November 29, 2019 02:06
@ablaom ablaom mentioned this pull request Mar 11, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants