Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard deps and run docs only on #master #322

Merged
merged 7 commits into from Nov 6, 2019
Merged

Hard deps and run docs only on #master #322

merged 7 commits into from Nov 6, 2019

Conversation

tlienart
Copy link
Collaborator

@tlienart tlienart commented Nov 5, 2019

  • cleans up duplicate and inconsistent import and using statements
  • removes requires and optional deps and clean up project.toml as a result
  • fixes travis to only test docs on master

all runs, there's one thing that fails but seems unrelated (I had it when testing before changing anything)

M = scitype(rms)
@test_broken M().prediction_type == :deterministic

I suggest we merge this and figure out the prediction type issue in another PR as it's a minor issue.

This should be merged after JuliaAI/ScientificTypes.jl#38 (1) and JuliaAI/MLJBase.jl#78 (2) are merged (particularly (2) as it depends upon it for the @load_*)

@tlienart
Copy link
Collaborator Author

tlienart commented Nov 5, 2019

That should be ready to merge (after the MLJBase one), also @ablaom see how https://travis-ci.com/alan-turing-institute/MLJ.jl/builds/135124126 does not test the docs FYI

@ablaom
Copy link
Collaborator

ablaom commented Nov 5, 2019

I'm happy with this and it looks like tests are going to pass. Will merge after tests and JuliaAI/MLJBase.jl#78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants