Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Recruitment FAQs #139

Merged
merged 12 commits into from
Feb 21, 2024
Merged

Add Recruitment FAQs #139

merged 12 commits into from
Feb 21, 2024

Conversation

KatrionaGoldmann
Copy link
Contributor

Summary

Add the recruitment FAQs to the handbook

Related issues

Copy link
Contributor

@yongrenjie yongrenjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! My suggestions are just to implement semantic line breaks :)

content/docs/join_us/recruitment_FAQs.md Outdated Show resolved Hide resolved
content/docs/join_us/recruitment_FAQs.md Outdated Show resolved Hide resolved
content/docs/join_us/recruitment_FAQs.md Outdated Show resolved Hide resolved
@yongrenjie
Copy link
Contributor

More broadly, should we have a followup issue somewhere that makes sure to change all the extant HackMD links once this is merged?

Or maybe we could keep the HackMD itself but remove its contents and put in a link to the handbook? Or both?

Would love to hear your thoughts @joseph-palmer 😄

KatrionaGoldmann and others added 3 commits February 19, 2024 11:10
Co-authored-by: Jonathan Yong <yongrenjie@gmail.com>
Co-authored-by: Jonathan Yong <yongrenjie@gmail.com>
Co-authored-by: Jonathan Yong <yongrenjie@gmail.com>
Copy link
Contributor

@IFenton IFenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I suspect we made need to update a few things when we actually open for the next recruitment round and know the details, but I think it's fine for the moment

content/docs/join_us/recruitment_FAQs.md Outdated Show resolved Hide resolved
KatrionaGoldmann and others added 4 commits February 19, 2024 15:39
Co-authored-by: Isabel Fenton <IFenton@users.noreply.github.com>
@yongrenjie
Copy link
Contributor

yongrenjie commented Feb 20, 2024

It seems the CI is failing because of an upgrade in Hugo from 0.122.0 to 0.123.0:

I'm not sure which of the new features in this version broke it, but the docs say that ref should take a link that's relative to the content directory, so changing

{{< ref "/content/docs/how_we_work/project_tracking.md" >}}

to

{{< ref "/docs/how_we_work/project_tracking.md" >}}

seems to fix it. Or maybe we should just standardise on relrefs?

@KatrionaGoldmann
Copy link
Contributor Author

Thanks @yongrenjie ! This saves me a job scouring for bugs. Will update these tomorrow.

Copy link

@joseph-palmer joseph-palmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KatrionaGoldmann KatrionaGoldmann marked this pull request as ready for review February 21, 2024 15:28
@KatrionaGoldmann KatrionaGoldmann merged commit 5dd25fb into main Feb 21, 2024
5 checks passed
@KatrionaGoldmann KatrionaGoldmann deleted the recruitment branch February 21, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add recruitment FAQ to handbook
4 participants