Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Review] Using wastewater data to monitor SARS-CoV-2 in England #207

Open
1 of 20 tasks
mhauru opened this issue Sep 30, 2022 · 18 comments
Open
1 of 20 tasks

[Review] Using wastewater data to monitor SARS-CoV-2 in England #207

mhauru opened this issue Sep 30, 2022 · 18 comments
Assignees

Comments

@mhauru
Copy link
Collaborator

mhauru commented Sep 30, 2022

Story Review: Using wastewater data to monitor SARS-CoV-2 in England

Story Name: Using wastewater data to monitor SARS-CoV-2 in England

Submitting Author: @AoifeHughes (Aoife Hughes)

Pull Request: #206

Reviewers: @radka-j (Radka Jersakova), @callummole (Callum Mole)

Reviewer instructions & questions

Radka & Callum, please carry out your review in this issue by updating the checklist below, and writing new comments in case you have any questions. If you cannot edit the checklist please:

Any questions, concerns or suggestions regarding the review process please let @crangelsmith, @DavidBeavan or @samvanstroud know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Review Checklist

Code of conduct

  • I confirm that I read and will adhere to the Turing Data Stories code of conduct.

General checks

  • Notebook: Is the source code for this data story available as a notebook in the linked pull request?
  • Contribution and authorship: Are the authors clearly listed? Does the author list seem appropriate and complete?
  • Scope and eligibility: Does the submission contain an original and complete analysis of open data? Is the story aligned with the Turing Data Stories vision statement?

Reproducibility

  • Does the notebook run in a local environment?
  • Does the notebook build and run in binder?
  • Are all data sources openly accessible and properly cited with a link?
  • Are the data open, and do they have an explicit licence, provenance and attribution?

Pedagogy

  • Does the story demonstrate some specific data analysis or visualisation techniques?
  • Are these techniques well motivated?
  • Are these techniques well implemented?
  • Is the notebook well documented, using both markdown cells and comments in code cells?
  • Does the notebook have an introduction section motivating the story?
  • Does the notebook have a conclusion section discussing the main insight from the stories?
  • Is the paper well written (it does not require editing for structure, language, or writing quality)?

Context

  • Does the story give an insight into some societal issue?
  • Is the context around this issue well referenced (newspaper articles, scientific papers, etc.)?

Ethical

  • Is any linkage of datasets in the story unlikely to lead to an increased risk of the personal identification of individuals?
  • Is the Story truthful and clear about any limitations of the analysis (and potential biases in data)?
  • Is the Story unlikely to lead to negative social outcomes, such as (but not limited to) increasing discrimination or injustice?

AOB

If you have comments pertaining to particular parts of the story, please use the ReviewNB app to submit them.

Feel free to agree between yourselves on how to divide the review work.

@mhauru
Copy link
Collaborator Author

mhauru commented Sep 30, 2022

@all-contributors please add @callummole for review

@allcontributors
Copy link
Contributor

@mhauru

I've put up a pull request to add @callummole! 🎉

@mhauru
Copy link
Collaborator Author

mhauru commented Sep 30, 2022

@all-contributors please add @radka-j for review

@allcontributors
Copy link
Contributor

@mhauru

I've put up a pull request to add @radka-j! 🎉

@mhauru
Copy link
Collaborator Author

mhauru commented Sep 30, 2022

@all-contributors please add @AoifeHughes for ideas

@allcontributors
Copy link
Contributor

@mhauru

I've put up a pull request to add @AoifeHughes! 🎉

@mhauru
Copy link
Collaborator Author

mhauru commented Sep 30, 2022

@all-contributors please add @AoifeHughes for content

@allcontributors
Copy link
Contributor

@mhauru

I've put up a pull request to add @AoifeHughes! 🎉

@mhauru
Copy link
Collaborator Author

mhauru commented Sep 30, 2022

@all-contributors please add @AoifeHughes for code

@allcontributors
Copy link
Contributor

@mhauru

I've put up a pull request to add @AoifeHughes! 🎉

@mhauru
Copy link
Collaborator Author

mhauru commented Sep 30, 2022

@all-contributors please add @AoifeHughes for data

@allcontributors
Copy link
Contributor

@mhauru

I've put up a pull request to add @AoifeHughes! 🎉

@callummole
Copy link
Collaborator

Hi. Very happy to review, but a bit unclear on what I should do. It says please carry out your review in this issue by updating the checklist below. Is the intended interpretation to copy the checklist and add the filled checklist as a comment to this issue?

@mhauru
Copy link
Collaborator Author

mhauru commented Oct 5, 2022

No, you can tick boxes in that main checklist in the issue body. This way if you've checked some aspect and ticked it, Radka will know she doesn't have to.

@crangelsmith
Copy link
Collaborator

No, you can tick boxes in that main checklist in the issue body. This way if you've checked some aspect and ticked it, Radka will know she doesn't have to.

Just to add to this, it makes sense on the reproducibility side that only one reviewer carries out the checks, but I think in the other sections both reviewers must agree that the requirement is fulfilled, given that it can be a bit more subjective.

@callummole
Copy link
Collaborator

I've reviewed the notebook and posted a bunch of comments. Well done, @AoifeHughes, it's looking really nice. Most of my comments are about the modelling.

@AoifeHughes
Copy link
Collaborator

Thanks for doing so quickly and throughly @callummole, I’ll go through and address soon! 😊

@AoifeHughes
Copy link
Collaborator

AoifeHughes commented Oct 11, 2022

Going to address things here and will update this list as I push updates, will notify when complete

For @AoifeHughes todo:

  • Address grammar
    • e01e9de does first paragraph and fixes filenames
    • 5a22ae4 Grammar until ### Averaging data for each region
  • Add links to additional instructional files
  • Clarity and conciseness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants