-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Review] Using wastewater data to monitor SARS-CoV-2 in England #207
Comments
@all-contributors please add @callummole for review |
I've put up a pull request to add @callummole! 🎉 |
@all-contributors please add @radka-j for review |
I've put up a pull request to add @radka-j! 🎉 |
@all-contributors please add @AoifeHughes for ideas |
I've put up a pull request to add @AoifeHughes! 🎉 |
@all-contributors please add @AoifeHughes for content |
I've put up a pull request to add @AoifeHughes! 🎉 |
@all-contributors please add @AoifeHughes for code |
I've put up a pull request to add @AoifeHughes! 🎉 |
@all-contributors please add @AoifeHughes for data |
I've put up a pull request to add @AoifeHughes! 🎉 |
Hi. Very happy to review, but a bit unclear on what I should do. It says |
No, you can tick boxes in that main checklist in the issue body. This way if you've checked some aspect and ticked it, Radka will know she doesn't have to. |
Just to add to this, it makes sense on the reproducibility side that only one reviewer carries out the checks, but I think in the other sections both reviewers must agree that the requirement is fulfilled, given that it can be a bit more subjective. |
I've reviewed the notebook and posted a bunch of comments. Well done, @AoifeHughes, it's looking really nice. Most of my comments are about the modelling. |
Thanks for doing so quickly and throughly @callummole, I’ll go through and address soon! 😊 |
Going to address things here and will update this list as I push updates, will notify when complete For @AoifeHughes todo: |
Story Review: Using wastewater data to monitor SARS-CoV-2 in England
Story Name: Using wastewater data to monitor SARS-CoV-2 in England
Submitting Author: @AoifeHughes (Aoife Hughes)
Pull Request: #206
Reviewers: @radka-j (Radka Jersakova), @callummole (Callum Mole)
Reviewer instructions & questions
Radka & Callum, please carry out your review in this issue by updating the checklist below, and writing new comments in case you have any questions. If you cannot edit the checklist please:
Any questions, concerns or suggestions regarding the review process please let @crangelsmith, @DavidBeavan or @samvanstroud know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Review Checklist
Code of conduct
General checks
Reproducibility
Pedagogy
Context
Ethical
AOB
If you have comments pertaining to particular parts of the story, please use the ReviewNB app to submit them.
Feel free to agree between yourselves on how to divide the review work.
The text was updated successfully, but these errors were encountered: