Merge pull request #1974 from alan-turing-institute/fix_firewall_prio…

…rity Add new priority for workspace denied
alan-turing-institute · Jun 29, 2024 · 87fe39b · 87fe39b
2 parents 75fc1a0 + cc8febb
commit 87fe39b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/data_safe_haven/infrastructure/programs/sre/firewall.py b/data_safe_haven/infrastructure/programs/sre/firewall.py
@@ -244,7 +244,7 @@ def __init__(
                         type=network.AzureFirewallRCActionType.DENY
                     ),
                     name="workspaces-deny",
-                    priority=FirewallPriorities.SRE_WORKSPACES,
+                    priority=FirewallPriorities.SRE_WORKSPACES_DENY,
                     rules=[
                         network.AzureFirewallApplicationRuleArgs(
                             description="Deny external Ubuntu Snap Store upload and login access",

diff --git a/data_safe_haven/types/enums.py b/data_safe_haven/types/enums.py
@@ -38,7 +38,8 @@ class FirewallPriorities(int, Enum):
     SRE_GUACAMOLE_CONTAINERS = 3100
     SRE_IDENTITY_CONTAINERS = 3200
     SRE_USER_SERVICES_SOFTWARE_REPOSITORIES = 3300
-    SRE_WORKSPACES = 3400
+    SRE_WORKSPACES_DENY = 3400
+    SRE_WORKSPACES = 3450
 
 
 @verify(UNIQUE)