Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change AllowExternalAzureAutomationOperations to a network rule #1804

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

jemrobinson
Copy link
Member

@jemrobinson jemrobinson commented Apr 15, 2024

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).
  • You have marked this pull request as a draft and added '[WIP]' to the title if needed (if you're not yet ready to merge).

⤴️ Summary

AllowExternalAzureAutomationOperations needs an application rule to filter on protocol/type and a network rule to filter on traffic type.

🌂 Related issues

Fix small bug from #1781

🔬 Tests

Not tested

@jemrobinson jemrobinson added this to the Release 5.0.0rc2 milestone Apr 15, 2024
@jemrobinson jemrobinson requested a review from a team as a code owner April 15, 2024 11:20
@JimMadge JimMadge merged commit 1788895 into alan-turing-institute:develop Apr 15, 2024
10 checks passed
@jemrobinson jemrobinson deleted the 1781-bug-fix branch April 19, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants