-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move SHM firewall to SRE #1872
Merged
jemrobinson
merged 13 commits into
alan-turing-institute:develop
from
jemrobinson:1871-sre-firewall
May 16, 2024
Merged
Move SHM firewall to SRE #1872
jemrobinson
merged 13 commits into
alan-turing-institute:develop
from
jemrobinson:1871-sre-firewall
May 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
98e2ddb
to
21e48b4
Compare
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
21e48b4
to
838a924
Compare
1507a98
to
a6584b1
Compare
0cccd23
to
c7490f0
Compare
JimMadge
requested changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Just a few suggestions for where we can add tests and some questions.
3d9d8b3
to
fa96431
Compare
JimMadge
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
Enable foobar integration
rather than515 foobar
).develop
.'[WIP]'
to the title if needed (if you're not yet ready to merge).🚦 Depends on
Must be merged after #1883
Replace the SHM Standard firewall with an SRE Basic firewall
=> SRE Basic firewall costs ~30% as much as the SHM Standard firewall
🌂 Related issues
Closes #1871
🔬 Tests
Tested on a fresh SRE deployment