Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in docs #92

Closed
wants to merge 3 commits into from
Closed

Conversation

nilsleh
Copy link

@nilsleh nilsleh commented Nov 8, 2023

Just adding a missing character in the otherwise super insightful new documentation user guide!

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@nilsleh
Copy link
Author

nilsleh commented Nov 8, 2023

I tried but did not succeed in only changing the typo without changing some of the notebook metadata, maybe you can give me a pointer @kallewesterling ?

@tom-andersson
Copy link
Collaborator

Hey @nilsleh, thank you for catching this typo!

We're still working on clear documentation contribution guidelines and not really soliciting contributions just yet. For example, the notebooks may require some special care to avoid merge conflicts due to the metadata changing. In the meantime we have issue #87 to collect feedback. Will close this in this instance, but I'm currently working on the finishing touches to the first draft of our docs and I'll incorporate your correction. Thanks again and keep an eye on the DeepSensor Slack for any updates.

P.S. In future for something small like a one-character change, it might be easier to just mention in #87 for someone to pick up when pushing more extensive changes.

cc @kallewesterling in case of further comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants