-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation of the review process #117
Conversation
✅ Deploy Preview for the-environmental-ds-book ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@EstherPlomp thanks for your great inputs and feedback of the Open Peer Review guidelines for EDS book notebooks. I've addressed all your comments, please let me know if you have any additional observations. The optimal timings for publication when notebook starts the REVIEW stage are 2 weeks review, 2 weeks changes, 1 week reviewers approval. These timings are based on PyOpenSci. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@annefou thanks for contributing to the proposed guidelines and sections covered in this PR. I went through your comments and addressed most of them. Everything is ready for you to review it again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice guidelines; much more comprehensive and clearer. Thanks a lot!
Thanks everyone for your contribution I'll merge it in preparation to #126. |
Before review
Description
The PR aims to improve guidelines and details of the submission and reviewing process. It also make some general changes for improving the user experience of the notebook as follows:
Motivation and Context
Fixes #115
How has this been tested?
No major changes. Local run in MacOS to build the plain markdowns.
Types of changes
Checklist:
Additional information