Module 5 updates #109
Merged
Module 5 updates #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
helendduncan
reviewed
Aug 8, 2022
| "rootdir: /home/turingdev/research-software/rse-course/ch03tests/diffusion\n", | ||
| "plugins: cov-2.12.1, anyio-3.3.0\n", | ||
| "collected 1 item\n", | ||
| "platform darwin -- Python 3.9.9, pytest-7.1.2, pluggy-1.0.0\n", |
There was a problem hiding this comment.
Is the intended behaviour here for the test to "pass" as previously or to give an error message?
There was a problem hiding this comment.
I think it's failing because of the blank
def test_energy():
# Test somethingthat's created in the cell above. Adding a single "return" or "..." line should fix it - would you mind adding it?
There was a problem hiding this comment.
What's the broken link?
There was a problem hiding this comment.
pass is a good no-op in Python if you need one.
helendduncan
reviewed
Aug 8, 2022
| @@ -920,7 +920,7 @@ | |||
| "cell_type": "markdown", | |||
| "metadata": {}, | |||
| "source": [ | |||
| "[We have seen before](../ch01data/060files.html#Closing-files) [[notebook](../ch01data/060files.ipynb#Closing-files)] that, instead of separately `open`ing and `close`ing a file, we can have\n", | |||
| "[We have seen before](../module02_intermediate_python/02_04_working_with_files.html#Closing-files) [[notebook](../module02_intermediate_python/02_04_working_with_files.ipynb#Closing-files)] that, instead of separately `open`ing and `close`ing a file, we can have\n", | |||
There was a problem hiding this comment.
@jack89roberts hopefully this fixes the broken links?
helendduncan
approved these changes
Aug 8, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nosewithpytesteverywhere#88