Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix incorrect "uses X" tag for ARIMA and TrendForecaster #1895

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

ngupta23
Copy link
Contributor

Reference Issues/PRs

Fixes #1835

What does this implement/fix? Explain your changes.

Fixed incorrect tags for exogenous variable support

Does your contribution introduce a new dependency? If yes, which one?

No

What should a reviewer concentrate their feedback on?

Correct support for tags for exogenous variables.

Any other comments?

NA

PR checklist

For all contributions
  • I've added myself to the list of contributors.
  • Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
  • I've added unit tests and made sure they pass locally.
For new estimators
  • I've added the estimator to the online documentation.
  • I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this looks correct, thanks for flagging this!

@fkiraly fkiraly merged commit 419d347 into sktime:main Jan 19, 2022
@fkiraly fkiraly changed the title Fix for forecasting tags [BUG] Fix incorredt "uses X" tag for ARIMA and TrendForecaster Jan 19, 2022
@fkiraly fkiraly changed the title [BUG] Fix incorredt "uses X" tag for ARIMA and TrendForecaster [BUG] Fix incorrect "uses X" tag for ARIMA and TrendForecaster Jan 19, 2022
@ngupta23 ngupta23 deleted the tags branch January 21, 2022 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ignores-exogeneous tag incorrectly set in a few forecasters
2 participants