-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] improved docstrings for HIVE-COTE v1.0 #2239
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthewMiddlehurst
previously approved these changes
Mar 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only STC uses OOB, rest use CV as normal. Mostly because RISE and TSF don't have it implemented 🙂.
Can change it to clarify that, going to approve either way as it's a good addition.
MatthewMiddlehurst
approved these changes
Mar 17, 2022
srggrs
added a commit
to Gridsight/sktime
that referenced
this pull request
Mar 22, 2022
* upstream/main: (79 commits) [ENH] Upgrade of `BaseTransformer` to use vectorization utility, hierarchical mtype compatibility (sktime#2219) [ENH] factory to add 3D capability to all distances exported by distances module (sktime#2051) [ENH] Relaxing `pd-multiindex` mtype to allow string instance index (sktime#2262) [ENH] refactoring `test_all_classifiers` to test class architecture (sktime#2257) [BUG] fixing `STLBootstrapTransformer` error message and docstrings (sktime#2260) [ENH] Add AutoARIMA from StatsForecast (sktime#2251) [ENH] `predict_proba` for forecasters, `tensorflow-probability` dependency (sktime#2100) [DOC] simplified extension templates for transformers and forecasters (sktime#2161) [ENH] full support for `Panel.numpyflat` mtype in `datatypes` module, checks/conversions (sktime#1772) [BUG] fix `FeatureUnion` test failure mk4 (sktime#1810) [ENH] renamed `fit-in-transform` and `fit-in-predict` to `fit_is_empty` (sktime#2250) [ENH] tag aliasing mixin for aliasing and deprecation of tags (sktime#1962) [ENH] Classifier type hints (sktime#2246) [ENH] Improved design for probabilistic error metrics (sktime#2232) remove test for StratifiedGroupKFold (sktime#2244) [DOC] typo fix and minor clarification in estimator implementation guide (sktime#2241) [DOC] improved docstrings for HIVE-COTE v1.0 (sktime#2239) [DOC] New estimator implementation guide (sktime#2186) [DOC] add scitype/mtype register pointers to docstrings in datatypes (sktime#2160) [ENH] sklearn typing util (sktime#2208) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2213 (hopefully) by expanding the docstring comments about the implementationin hive-cote v1.0