Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] improved docstrings for HIVE-COTE v1.0 #2239

Merged
merged 5 commits into from
Mar 18, 2022
Merged

[DOC] improved docstrings for HIVE-COTE v1.0 #2239

merged 5 commits into from
Mar 18, 2022

Conversation

TonyBagnall
Copy link
Contributor

fixes #2213 (hopefully) by expanding the docstring comments about the implementationin hive-cote v1.0

Copy link
Contributor

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only STC uses OOB, rest use CV as normal. Mostly because RISE and TSF don't have it implemented 🙂.

Can change it to clarify that, going to approve either way as it's a good addition.

@fkiraly fkiraly changed the title comments [DOC] improved docstrings for HIVE-COTE v1.0 Mar 17, 2022
@TonyBagnall TonyBagnall merged commit 29a7224 into main Mar 18, 2022
@TonyBagnall TonyBagnall deleted the hc1_comments branch March 18, 2022 10:08
@lmmentel lmmentel added the documentation Documentation & tutorials label Mar 21, 2022
srggrs added a commit to Gridsight/sktime that referenced this pull request Mar 22, 2022
* upstream/main: (79 commits)
  [ENH] Upgrade of `BaseTransformer` to use vectorization utility, hierarchical mtype compatibility (sktime#2219)
  [ENH] factory to add 3D capability to all distances exported by distances module (sktime#2051)
  [ENH] Relaxing `pd-multiindex` mtype to allow string instance index (sktime#2262)
  [ENH] refactoring `test_all_classifiers` to test class architecture (sktime#2257)
  [BUG] fixing `STLBootstrapTransformer` error message and docstrings (sktime#2260)
  [ENH] Add AutoARIMA from StatsForecast  (sktime#2251)
  [ENH] `predict_proba` for forecasters, `tensorflow-probability` dependency (sktime#2100)
  [DOC] simplified extension templates for transformers and forecasters (sktime#2161)
  [ENH] full support for `Panel.numpyflat` mtype in `datatypes` module, checks/conversions (sktime#1772)
  [BUG] fix `FeatureUnion` test failure mk4 (sktime#1810)
  [ENH] renamed `fit-in-transform` and `fit-in-predict` to `fit_is_empty` (sktime#2250)
  [ENH] tag aliasing mixin for aliasing and deprecation of tags (sktime#1962)
  [ENH] Classifier type hints (sktime#2246)
  [ENH] Improved design for probabilistic error metrics (sktime#2232)
  remove test for StratifiedGroupKFold (sktime#2244)
  [DOC] typo fix and minor clarification in estimator implementation guide (sktime#2241)
  [DOC] improved docstrings for HIVE-COTE v1.0 (sktime#2239)
  [DOC] New estimator implementation guide (sktime#2186)
  [DOC] add scitype/mtype register pointers to docstrings in datatypes (sktime#2160)
  [ENH] sklearn typing util (sktime#2208)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation & tutorials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Benchmark of HC2 and HC1 do not match paper results
3 participants