-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] remove fit_params
kwargs throughout the code base
#2343
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you check what those params could have been? We might add them to constructor as we did for statsmodels
in another PR
As far as I saw, only occurred in compositors, and logic passing the kwargs from composite interfaces to component interfaces. Plus pmdarima, I'll open an issue for it: #2344 |
I checked for |
@aiwalter, are there any |
Added |
Co-authored-by: Martin Walter <mf-walter@web.de>
@aiwalter, this has now come up so often, I've added a paragraph to extension templates in |
…titute/sktime into remove-fitparams
yes, seems many dependency packages are doing this, so we have to add it to constructor. Makes sense to add it to template. Thx |
As pointed out by @Vasudeva-bit, some estimators were still using a
fit_params
kwarg in_fit
.This is non-compliant with the interface spec, but did not cause any errors since never anything was passed by kwargs.
This PR simply removes any
fit_params
kwargs and concomitant logic from the code base.Needs no deprecation, since:
evaluate
had the arg, but when used it would error out since nofit
actually had the arg, so deprecation is also not necessary here (because we are changing from an "error causing argument" to "no argument", hence no one will have relied on it).Since this seems to be a frequent issue for extenders, I've added a paragraph to
_fit
in the classification, forecasting, and transformer extension templates (where it is most likely encountered due to interfacing as opposed to implementation from scratch).