Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] clean-up of test_random_state #2593

Merged
merged 2 commits into from
May 1, 2022
Merged

[ENH] clean-up of test_random_state #2593

merged 2 commits into from
May 1, 2022

Conversation

Ris-Bali
Copy link
Contributor

@Ris-Bali Ris-Bali commented May 1, 2022 •
edited
Loading

Reference Issues/PRs

#2440

What does this implement/fix? Explain your changes.

Fixes minor issues as mentioned in #2440

Does your contribution introduce a new dependency? If yes, which one?

No

What should a reviewer concentrate their feedback on?

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors.
  • Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
  • I've added unit tests and made sure they pass locally.
  • The PR title starts with either [ENH], [DOC] or [BUG] indicating whether the PR topic is related to enhancement, documentation or bug
For new estimators
  • I've added the estimator to the online documentation.
  • I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

@Ris-Bali Ris-Bali marked this pull request as ready for review May 1, 2022 14:12
fkiraly
fkiraly approved these changes May 1, 2022
View reviewed changes
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up with this!

@fkiraly fkiraly changed the title Fixes minor issues in randomtest [ENH] clean-up of test_random_state May 1, 2022
@fkiraly fkiraly merged commit 714e365 into sktime:main May 1, 2022
@lmmentel lmmentel added the maintenance Continuous integration, unit testing & package distribution label May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkiraly fkiraly fkiraly approved these changes

@mloning mloning Awaiting requested review from mloning

@aiwalter aiwalter Awaiting requested review from aiwalter

Assignees
No one assigned
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ris-Bali @fkiraly @lmmentel