[BUG] changed wrong docstring default value of start_with_window in SlidingWindowSplitter to actual default value

[pmuls99]

Reference Issues/PRs

Fixes #3315.

What does this implement/fix? Explain your changes.

The default value was mentioned to be False, but it should be True, in the code, it has been rightly used but, in the comments, there was an error. Changed the default value.

What should a reviewer concentrate their feedback on?

Any other comments?

PR checklist

For all contributions

• I've added myself to the list of contributors.
• Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
• I've added unit tests and made sure they pass locally.
• The PR title starts with either [ENH], [MNT], [DOC], or [BUG] indicating whether the PR topic is related to enhancement, maintenance, documentation, or bug.

For new estimators

• I've added the estimator to the online documentation.
• I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

[fkiraly]

Straightforward fix, thanks!

[fkiraly]

the bug has been slayed, but the linter is dismayed

[fkiraly]

... or, slain?

[pmuls99]

I am not sure why are these tests are failing :(. Can you tell what can I do now?

[fkiraly]

code formatting. Click here to see the code quality checker report:

You can also set this up locally - very helpful, see sktime developer gude here:
https://www.sktime.org/en/stable/developer_guide/coding_standards.html

Side note: it is in code that you didn't change, but it rechecks entire files where changes occur. There was a change in the linter defaults around exponent spacing recently, so now it notices it for the file you changed.

[pmuls99]

@fkiraly do i need to create a new PR now ?

[fkiraly]

@fkiraly do i need to create a new PR now ?

No, just push new commits to your branch, and the PR will update, too.

[pmuls99]

@fkiraly, have done. Can you see once.

[pmuls99]

@aiwalter Can you take a look?

[pmuls99]

@fkiraly, @aiwalter code satisfying the coding standards. Still, the tests are failing. Does this mean that this code might not work on those Operating systems? If yes, what might be the fix, I have observed similar tests failing in other PRs as well.

[fkiraly]

Failures are not your fault, related to another estimator that made it onto main by accident (the one failing the test), see here: #3350

if you update your branch from main, it should all be fine.

[pmuls99]

@fkiraly, can you approve the running workflow?

[pmuls99]

@fkiraly all the tests have passed. Now can you please merge the code?