Skip to content

Commit

Permalink
[BUG] changed wrong docstring default value of start_with_window in…
Browse files Browse the repository at this point in the history
… `SlidingWindowSplitter` to actual default value (#3340)

Fixes #3315.
Changes wrong docstring default value of `start_with_window` in `SlidingWindowSplitter` to actual default value.

The default value was mentioned to be False, but it should be True, in the code, it has been rightly used but, in the docstring, there was an error. Changed the default value in the docstring.
  • Loading branch information
pmuls99 committed Aug 27, 2022
1 parent b4db673 commit 86506e1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion sktime/forecasting/model_selection/_split.py
Original file line number Diff line number Diff line change
Expand Up @@ -1106,7 +1106,7 @@ class SlidingWindowSplitter(BaseWindowSplitter):
Step length between windows
initial_window : int or timedelta or pd.DateOffset, optional (default=None)
Window length of first window
start_with_window : bool, optional (default=False)
start_with_window : bool, optional (default=True)
- If True, starts with full window.
- If False, starts with empty window.
Expand Down
2 changes: 2 additions & 0 deletions sktime/transformations/series/boxcox.py
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,7 @@ def _transform(self, X, y=None):
y : ignored argument for interface compatibility
Additional data, e.g., labels for transformation
Returns
-------
Xt : 2D np.ndarray
Expand All @@ -285,6 +286,7 @@ def _inverse_transform(self, X, y=None):
y : ignored argument for interface compatibility
Additional data, e.g., labels for transformation
Returns
-------
Xt : 2D np.ndarray
Expand Down

0 comments on commit 86506e1

Please sign in to comment.