Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo pmdarima hotfix and avoid pmdarima 1.8.1 #831

Merged
merged 2 commits into from
Apr 20, 2021
Merged

Undo pmdarima hotfix and avoid pmdarima 1.8.1 #831

merged 2 commits into from
Apr 20, 2021

Conversation

aaronreidsmith
Copy link
Contributor

Reference Issues/PRs

Reverts hotfix from #828 (also see alkaline-ml/pmdarima#423) and pins so pmdarima 1.8.1 is avoided.

What does this implement/fix? Explain your changes.

Removes the need for the hotfix and keeps numpy compatibility.

Does your contribution introduce a new dependency? If yes, which one?

No, just fixes an existing one 🙂

What should a reviewer concentrate their feedback on?

N/A

Any other comments?

Sorry I pushed a bad pmdarima version yesterday 😅

PR checklist

For all contributions
  • I've added myself to the list of contributors.
  • Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
  • I've added unit tests and made sure they pass locally.
For new estimators
  • I've added the estimator to the online documentation.
  • I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

Copy link
Contributor

@mloning mloning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aaronreidsmith - much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants