Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ready for Review] Update BinderHub workshop #1552

Merged
merged 9 commits into from
Mar 9, 2021

Conversation

sgibson91
Copy link
Member

@sgibson91 sgibson91 commented Nov 10, 2020

Summary

This PR is a reconstruction of #762

Addresses #694

This PR is implementing improvements to the Zero to BinderHub workshop recommended through feedback from RSE Con UK 2019.

List of changes proposed in this PR (pull-request)

  • See check list in issue Reflections on Build A BinderHub workshop #694 for changes to the actual workshop.
  • Helm section has been made Helm3 compatible
  • A hackmd template has been added for collecting feedback/distributing links during the workshop

What should a reviewer concentrate their feedback on?

  • Everything looks ok?

Acknowledging contributors

@netlify
Copy link

netlify bot commented Nov 10, 2020

Deploy preview for the-turing-way ready!

Built with commit 72a4b32

https://deploy-preview-1552--the-turing-way.netlify.app

@sgibson91 sgibson91 changed the title [WIP] Update BinderHub workshop [Ready for Review] Update BinderHub workshop Nov 10, 2020
@malvikasharan malvikasharan added the book-dash-nov20 This is to be used on issues and PR during/for the book dash in Nov 2020 label Nov 13, 2020
@malvikasharan
Copy link
Collaborator

Not sure who should look at this one. Gonna tag @betatim if he can suggest someone who can review this.

@sgibson91
Copy link
Member Author

@consideRatio might be able to help?

@sgibson91
Copy link
Member Author

Thanks @Lovkush-A, I've addressed all your points! 🙌🏻

@sgibson91
Copy link
Member Author

sgibson91 commented Mar 2, 2021

If this PR is not getting reviewed/approved because folk feel like they don't know enough about kubernetes and/or helm, all that really needs to be reviewed is whether the instructions in zero-to-binderhub.md follow along with/make sense compared to the Azure instructions in the Zero to JupyterHub docs, as this is basically just an Azure-specific, one-pager copy of those docs.

@Lovkush-A
Copy link
Contributor

@sgibson91 I tried having a look and comparing with the resources on jupyterhub and binderhub. It looks like they match up.

@sgibson91
Copy link
Member Author

Hey @Lovkush-A, I think I have addressed all your comments. If you're happy, can you approve this Pull Request following the steps here please? (But select "Approve", not "Request Changes" like in the screenshot!) Then the PR will be mergeable. Thank you! 👾

Copy link
Contributor

@Lovkush-A Lovkush-A left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgibson91 All changes look good!

Also worth saying that tutorial looks in top shape; very clear and concise. Despite me having no idea about most of the content, I was able to follow along in the tutorial and make sense of the instructions!

@sgibson91 sgibson91 merged commit a5ef832 into the-turing-way:master Mar 9, 2021
@sgibson91 sgibson91 deleted the update-z2bh-workshop branch March 9, 2021 09:35
@sgibson91
Copy link
Member Author

Thank you @Lovkush-A, glad to know it's a useful resource!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
book-dash-nov20 This is to be used on issues and PR during/for the book dash in Nov 2020 PR: merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants