-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ready for Review] Update BinderHub workshop #1552
[Ready for Review] Update BinderHub workshop #1552
Conversation
Deploy preview for the-turing-way ready! Built with commit 72a4b32 |
Not sure who should look at this one. Gonna tag @betatim if he can suggest someone who can review this. |
@consideRatio might be able to help? |
workshops/build-a-binderhub/binderhub_resources/collaborative_notes_template.md
Outdated
Show resolved
Hide resolved
workshops/build-a-binderhub/binderhub_resources/collaborative_notes_template.md
Outdated
Show resolved
Hide resolved
workshops/build-a-binderhub/binderhub_resources/collaborative_notes_template.md
Outdated
Show resolved
Hide resolved
workshops/build-a-binderhub/binderhub_resources/collaborative_notes_template.md
Outdated
Show resolved
Hide resolved
workshops/build-a-binderhub/binderhub_resources/collaborative_notes_template.md
Outdated
Show resolved
Hide resolved
workshops/build-a-binderhub/binderhub_resources/collaborative_notes_template.md
Outdated
Show resolved
Hide resolved
Thanks @Lovkush-A, I've addressed all your points! 🙌🏻 |
If this PR is not getting reviewed/approved because folk feel like they don't know enough about kubernetes and/or helm, all that really needs to be reviewed is whether the instructions in |
workshops/build-a-binderhub/workshop-presentations/zero-to-binderhub.md
Outdated
Show resolved
Hide resolved
workshops/build-a-binderhub/workshop-presentations/zero-to-binderhub.md
Outdated
Show resolved
Hide resolved
workshops/build-a-binderhub/workshop-presentations/zero-to-binderhub.md
Outdated
Show resolved
Hide resolved
workshops/build-a-binderhub/workshop-presentations/zero-to-binderhub.md
Outdated
Show resolved
Hide resolved
workshops/build-a-binderhub/workshop-presentations/zero-to-binderhub.md
Outdated
Show resolved
Hide resolved
@sgibson91 I tried having a look and comparing with the resources on jupyterhub and binderhub. It looks like they match up. |
workshops/build-a-binderhub/workshop-presentations/zero-to-binderhub.md
Outdated
Show resolved
Hide resolved
workshops/build-a-binderhub/workshop-presentations/zero-to-binderhub.md
Outdated
Show resolved
Hide resolved
workshops/build-a-binderhub/workshop-presentations/zero-to-binderhub.md
Outdated
Show resolved
Hide resolved
workshops/build-a-binderhub/workshop-presentations/zero-to-binderhub.md
Outdated
Show resolved
Hide resolved
workshops/build-a-binderhub/workshop-presentations/zero-to-binderhub.md
Outdated
Show resolved
Hide resolved
Hey @Lovkush-A, I think I have addressed all your comments. If you're happy, can you approve this Pull Request following the steps here please? (But select "Approve", not "Request Changes" like in the screenshot!) Then the PR will be mergeable. Thank you! 👾 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sgibson91 All changes look good!
Also worth saying that tutorial looks in top shape; very clear and concise. Despite me having no idea about most of the content, I was able to follow along in the tutorial and make sense of the instructions!
Thank you @Lovkush-A, glad to know it's a useful resource! |
Summary
This PR is a reconstruction of #762
Addresses #694
This PR is implementing improvements to the Zero to BinderHub workshop recommended through feedback from RSE Con UK 2019.
List of changes proposed in this PR (pull-request)
What should a reviewer concentrate their feedback on?
Acknowledging contributors