-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The easy way with Github chapter [Ready for review] #1559
Conversation
|
Deploy preview for the-turing-way ready! Built with commit c7272b5 |
Changed title to getting started on Github
split up some paragraphs to make it easier to read on a computer, and added some bullet points. also moved a couple of lines around to make them fit within the section.
@EKaroune for the 'getting started with github' chapter (https://github.com/alan-turing-institute/the-turing-way/blob/Easyway/book/website/collaboration/easyway/sc2_getting_started_with_github.md), I think some of the materials from the Mozilla Open Leadership files might be useful to link to or reference: https://github.com/mozilla/open-leadership-training-series. |
from easy way with github to getting started on github
remove the size parameter
I have made a few more commits to fix the broken image link and to ensure that the images do not appear distorted |
Feedback on "getting started with GitHub" chapter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look ok so please just approve them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge this one too.
Summary
New chapter for the reproducibility book on onboarding novice Github users. It has been edited by Malvika and Paul. Formatting needs to be checked further and also the links to the figures.
Fixes #
Lorem ipsum dolor sit amet, consectetur adipiscing.
List of changes proposed in this PR (pull-request)
Do any further changes to the content, if needed
check formatting of easyway.md
check formatting of easyway subchapters
check figure links work
check figure sizing is correct
Lorem ipsum dolor sit amet, consectetur adipiscing.
Lorem ipsum dolor sit amet, consectetur adipiscing.
What should a reviewer concentrate their feedback on?
have I included all of the relevant content?
are the figures clear?
do all the links work?
Everything looks ok?
Acknowledging contributors