Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The easy way with Github chapter [Ready for review] #1559

Merged
merged 36 commits into from
Dec 8, 2020
Merged

Conversation

EKaroune
Copy link
Collaborator

@EKaroune EKaroune commented Nov 10, 2020

Summary

New chapter for the reproducibility book on onboarding novice Github users. It has been edited by Malvika and Paul. Formatting needs to be checked further and also the links to the figures.

Fixes #

Lorem ipsum dolor sit amet, consectetur adipiscing.

List of changes proposed in this PR (pull-request)

  • Do any further changes to the content, if needed

  • check formatting of easyway.md

  • check formatting of easyway subchapters

  • check figure links work

  • check figure sizing is correct

  • Lorem ipsum dolor sit amet, consectetur adipiscing.

  • Lorem ipsum dolor sit amet, consectetur adipiscing.

What should a reviewer concentrate their feedback on?

  • have I included all of the relevant content?

  • are the figures clear?

  • do all the links work?

  • Everything looks ok?

Acknowledging contributors

@EKaroune EKaroune added reproducibility-book Content for reproducibility book PR: unreviewed book-dash-nov20 This is to be used on issues and PR during/for the book dash in Nov 2020 labels Nov 10, 2020
@EKaroune EKaroune self-assigned this Nov 10, 2020
@welcome
Copy link

welcome bot commented Nov 10, 2020

Thank You Banner
💖 Thanks for opening this pull request! 💖 The Turing Way community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines and filled in our pull request template to the best of your ability.
If you are submitting a new chapter, here are some things that will help get your pull request across the finish line! 🏁

  • Check you have removed all lorem ipsums from the chapter template (if you used it)
  • Check for any abbreviations or latin phrases (such as "e.g." or "i.e.") in your writing. See our style guide for more information on this topic.
  • Make sure you have added your new chapter to the Table of Contents

    We have Continuous Integration tests that check the writing style and will help you track down any slip-ups ♻️ The Netlify bot will also comment with a preview of the book with your additions so you can see how it will look once it's merged! 🎉

    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. If we don't acknowledge this pull request after 7 days, feel free to chat to us about it in our gitter channel.

@netlify
Copy link

netlify bot commented Nov 10, 2020

Deploy preview for the-turing-way ready!

Built with commit c7272b5

https://deploy-preview-1559--the-turing-way.netlify.app

KirstieJane and others added 6 commits November 12, 2020 09:51
Changed title to getting started on Github
split up some paragraphs to make it easier to read on a computer, and added some bullet points.
also moved a couple of lines around to make them fit within the section.
@LauraCarter
Copy link
Collaborator

@EKaroune for the 'getting started with github' chapter (https://github.com/alan-turing-institute/the-turing-way/blob/Easyway/book/website/collaboration/easyway/sc2_getting_started_with_github.md), I think some of the materials from the Mozilla Open Leadership files might be useful to link to or reference: https://github.com/mozilla/open-leadership-training-series.
They are licensed under the MIT license, the same as the Turing Way, which I think (@malvikasharan please correct me if I am wrong!) means we can use/remix them as we like?

@paulowoicho
Copy link
Collaborator

I have made a few more commits to fix the broken image link and to ensure that the images do not appear distorted

Copy link
Collaborator Author

@EKaroune EKaroune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look ok so please just approve them.

Copy link
Collaborator

@malvikasharan malvikasharan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge this one too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
book-dash-nov20 This is to be used on issues and PR during/for the book dash in Nov 2020 PR: merged reproducibility-book Content for reproducibility book
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants